Open
Conversation
Owner
|
Thanks for the PR! Is there a bug that needs to be fixed by updating dependencies? I'm planning on doing a refactor of this and changing some of the dependencies anyway. The refactor also includes adding tests (since I know how to do those better for CLIs now). If you have any ideas on tests to add, I'll be glad to take a PR for those. Also, if you set the |
|
without update dependencies, watch-cli is flagged by last npm version as insecure because of minimatch older than 3.0.2 and lodash older than 4.17.5 (so this update isn't fresh enougth to fix the issues signaled by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It kinda works that way, as the tests are missing I am not sure if something broke 😅